Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate mongodb #3157

Closed
wants to merge 1 commit into from
Closed

Feature gate mongodb #3157

wants to merge 1 commit into from

Conversation

oscartbeaumont
Copy link

@oscartbeaumont oscartbeaumont commented Aug 30, 2022

The Prisma Engines already feature gate the sql and monogodb in many crates throughout the workspace however this convention has not been followed everywhere. This PR fixes the code throughout the rest of the repository to follow the convention.

I very much understand this change isn't something that provides benefits to the core Prisma product and I can fully understand it being closed, however, this change is based on following a convention that was already set in the codebase. The main benefit behind this change is to provide a much-needed improvement to the compile time performance of Prisma Client Rust. Having to wait for the MongoDB connector to compile when using an SQL DB is slow and unnecessary.

This links to issue prisma/prisma#14890 although that issue is around splitting all database connectors into their own feature flags. That is something I would like to look into if this PR is accepted, however, I suspect those changes will be harder without having adverse effects on the development of the engines.

@oscartbeaumont oscartbeaumont requested a review from a team as a code owner August 30, 2022 20:01
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2022

CLA assistant check
All committers have signed the CLA.

@tomhoule
Copy link
Contributor

Hi @oscartbeaumont , thanks for the PR! I agree it's a valid concern, but we are iterating on how the core <-> connector split works in prisma, and this is extra friction. I actually walked back the features for sql and mongo connectors in the migration engine a while ago. We need a proper motivated design before we make a move on this topic, and we aren't ready for that at the moment. This is of course just one engineer's opinion and I'll let others chime in if there are other views.

@oscartbeaumont
Copy link
Author

That's completely fair. I kinda figured that would be the outcome but I thought it was worth a try anyway. Thanks for your time.
If you guys are ever ready to do a proper design do let me and @Brendonovich know. I think we are both willing to help out with changes to the Prisma engines if we can work with you on a plan for the changes that works for everyone involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants