Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prisma Engines already feature gate the
sql
andmonogodb
in many crates throughout the workspace however this convention has not been followed everywhere. This PR fixes the code throughout the rest of the repository to follow the convention.I very much understand this change isn't something that provides benefits to the core Prisma product and I can fully understand it being closed, however, this change is based on following a convention that was already set in the codebase. The main benefit behind this change is to provide a much-needed improvement to the compile time performance of Prisma Client Rust. Having to wait for the MongoDB connector to compile when using an SQL DB is slow and unnecessary.
This links to issue prisma/prisma#14890 although that issue is around splitting all database connectors into their own feature flags. That is something I would like to look into if this PR is accepted, however, I suspect those changes will be harder without having adverse effects on the development of the engines.