Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver-adapters): assertions in driver adapters #4211

Merged
merged 15 commits into from
Sep 11, 2023
Merged

feat(driver-adapters): assertions in driver adapters #4211

merged 15 commits into from
Sep 11, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Sep 7, 2023 •
edited
Loading

This PR:

  • adds assertions to the libquery smoke tests for Driver Adapters.
  • allows to run both @prisma/client and libquery assertions with a single command (e.g., pnpm planetscale)
  • updates the smoke-tests README + Prisma version, superseding those changes in fix(driver-adapters): Add studio command to smoke-tests #4220.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 7, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #4211 will not alter performance

Comparing feat/assert-in-driver-adapters (747f9f6) with main (4991945)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno marked this pull request as ready for review September 11, 2023 11:56
@jkomyno jkomyno requested a review from a team as a code owner September 11, 2023 11:56
@jkomyno jkomyno mentioned this pull request Sep 11, 2023
Merged
jkomyno and others added 3 commits September 11, 2023 17:01
@jkomyno @aqrln
chore: apply nit
192a38c 
Co-authored-by: Alexey Orlenko <alex@aqrln.net>
@jkomyno jkomyno merged commit 9e8c303 into main Sep 11, 2023
26 checks passed
@jkomyno jkomyno deleted the feat/assert-in-driver-adapters branch September 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@aqrln aqrln aqrln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkomyno @janpio @aqrln