-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracing): quote traceparent value in sql comment #4354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too per the spec!
CodSpeed Performance ReportMerging #4354 will not alter performanceComparing Summary
|
Hello, thanks for the reviews! Looking through the test failures, as well as some other PRs, I suspect they aren't related to this one. Just wanted to doublecheck is there anything I should do for this PR or is it just pending the milestone? |
Test failures look indeed good, nothing for you to do there. |
I noticed that the traceparent value isn't quoted when tracing is enabled, which can affect some parsers. Looking at the opentelemetry spec for sql comments, we can see all values including traceparent are single-quoted
https://open-telemetry.github.io/opentelemetry-sqlcommenter/#sample