Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): quote traceparent value in sql comment #4354

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

anuraaga
Copy link
Contributor

I noticed that the traceparent value isn't quoted when tracing is enabled, which can affect some parsers. Looking at the opentelemetry spec for sql comments, we can see all values including traceparent are single-quoted

https://open-telemetry.github.io/opentelemetry-sqlcommenter/#sample

@anuraaga anuraaga requested a review from a team as a code owner October 11, 2023 03:03
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@Druue Druue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too per the spec!

@Druue Druue added this to the 5.5.0 milestone Oct 11, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 11, 2023

CodSpeed Performance Report

Merging #4354 will not alter performance

Comparing anuraaga:quote-traceparentcomment (6ef9f2c) with main (5c4707e)

Summary

✅ 11 untouched benchmarks

@anuraaga
Copy link
Contributor Author

Hello, thanks for the reviews! Looking through the test failures, as well as some other PRs, I suspect they aren't related to this one. Just wanted to doublecheck is there anything I should do for this PR or is it just pending the milestone?

@janpio
Copy link
Contributor

janpio commented Oct 16, 2023

Test failures look indeed good, nothing for you to do there.
(We'll work on getting rid of these soon, just distracting right now)

@miguelff miguelff requested a review from a team as a code owner November 24, 2023 14:12
@miguelff miguelff requested review from jkomyno and Weakky and removed request for a team November 24, 2023 14:12
@miguelff miguelff merged commit f2e5886 into prisma:main Nov 29, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants