Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(qe): update mobc to include importcjj/mobc#86 #4379

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

miguelff
Copy link
Contributor

@miguelff miguelff requested a review from a team as a code owner October 23, 2023 15:30
@miguelff miguelff requested review from jkomyno and Weakky and removed request for a team October 23, 2023 15:30
@miguelff
Copy link
Contributor Author

Created as an integration branch, in case some of the tests in prisma/prisma depended on the previous (wrong) behavior described in importcjj/mobc#82

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2023

CodSpeed Performance Report

Merging #4379 will not alter performance

Comparing integration/bump-mobc (411821c) with main (e0f0b06)

Summary

✅ 11 untouched benchmarks

@miguelff
Copy link
Contributor Author

According to prisma/prisma#21591 there aren't failing tests after upgrading mobc.

@Jolg42
Copy link
Contributor

Jolg42 commented Oct 24, 2023

@miguelff it would be interesting to review tests, we should have had one catching this change ideally, right?

@janpio janpio changed the title chore(qe) update mobc after to include importcjj/mobc#86 chore(qe): update mobc after to include importcjj/mobc#86 Oct 25, 2023
@miguelff miguelff changed the title chore(qe): update mobc after to include importcjj/mobc#86 chore(qe): update mobc to include importcjj/mobc#86 Oct 30, 2023
@janpio janpio added this to the 5.6.0 milestone Nov 13, 2023
@miguelff
Copy link
Contributor Author

miguelff commented Nov 13, 2023

I don't want to encode in the tests specific values for queries, because depending on pool sizes, those will behave differently. What I observed is that before (main) reported idle = pool size, while now, it reports 1. Which is the expected, correct behavior.

This can sometimes be reported as 1 or 0, and lead to flakey tests, tho' as metrics are reported asynchronously.

main.txt
branch.txt

Screenshot 2023-11-13 at 17 09 24

@Jolg42
Copy link
Contributor

Jolg42 commented Nov 13, 2023

Right!

My thinking is that we could expect 0 or 1 for prisma_pool_connections_idle, I think that's better than nothing. Though not ideal.

@janpio janpio requested a review from Jolg42 November 13, 2023 17:44
@miguelff miguelff merged commit e95e739 into main Nov 13, 2023
53 of 57 checks passed
@miguelff miguelff deleted the integration/bump-mobc branch November 13, 2023 17:48
Jolg42 added a commit to prisma/prisma that referenced this pull request Nov 14, 2023
@Jolg42 Jolg42 added tech/engines Issue for tech Engines. topic: tech debt labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech/engines Issue for tech Engines. topic: tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prisma_pool_connections_idle reports misleading number
3 participants