Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update engineer version for .finish detection logic #4434

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Nov 10, 2023

@Jolg42 Jolg42 added this to the 5.6.0 milestone Nov 13, 2023
@Jolg42 Jolg42 changed the title update engineer version for .finish detection logic ci: update engineer version for .finish detection logic Nov 13, 2023
@Jolg42 Jolg42 requested a review from miguelff November 13, 2023 11:39
@Jolg42 Jolg42 marked this pull request as ready for review November 13, 2023 11:39
@Jolg42 Jolg42 requested a review from jkomyno November 13, 2023 11:40
Copy link
Contributor

@miguelff miguelff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was 1.61 never used?

@Jolg42
Copy link
Contributor Author

Jolg42 commented Nov 13, 2023

@miguelff indeed, https://github.com/prisma/engineer/releases/tag/1.61 was not used.

@jkomyno created it but then we found out that it was not doing what we expected and 1.62 now happened.

@Jolg42 Jolg42 merged commit 174e7d3 into main Nov 13, 2023
5 checks passed
@Jolg42 Jolg42 deleted the joel/engineer-finished branch November 13, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants