Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psl: Make prismaSchemaFolder feature public #4896

Merged
merged 3 commits into from
Jun 3, 2024
Merged

psl: Make prismaSchemaFolder feature public #4896

merged 3 commits into from
Jun 3, 2024

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented May 31, 2024

No description provided.

@SevInf SevInf added this to the 5.15.0 milestone May 31, 2024
@SevInf SevInf requested a review from a team as a code owner May 31, 2024 09:48
@SevInf SevInf requested review from jkomyno and removed request for a team May 31, 2024 09:48
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4896 will not alter performance

Comparing schema-folder-public (cd42331) with main (3a14d17)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.042MiB 2.042MiB 0.000B
Postgres (gzip) 813.791KiB 813.790KiB 1.000B
Mysql 2.012MiB 2.012MiB 0.000B
Mysql (gzip) 800.069KiB 800.071KiB -2.000B
Sqlite 1.914MiB 1.914MiB 0.000B
Sqlite (gzip) 762.792KiB 762.792KiB 1.000B

@Jolg42
Copy link
Contributor

Jolg42 commented May 31, 2024

For info, tests are failing @SevInf, example:
https://github.com/prisma/prisma-engines/actions/runs/9316278362/job/25644186632?pr=4896#step:4:364
Screenshot 2024-05-31 at 11 53 28

@nlynzaad nlynzaad mentioned this pull request May 31, 2024
Open
@SevInf SevInf merged commit 7320bfa into main Jun 3, 2024
207 checks passed
@SevInf SevInf deleted the schema-folder-public branch June 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

@Jolg42 Jolg42 Jolg42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SevInf @Jolg42 @jkomyno