tech(quaint): surface mysql socket as host if in use #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rroring what we expect in PG and CRDB. This means that errors will now surface the socket connection to users when encountering, for example, connectivity issues. This was already happening by default for PG and CRDB as they expect sockets through the `host` query-arg, however our default host parsing was not picking this up for MySQL as it was expected through `socket` there instead. Related PR: prisma/prisma#24222
CodSpeed Performance ReportMerging #4917 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
SevInf
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MySQL url parsing to surface the socket as host if in use, mirroring what we expect in PG and CRDB.
This means that errors will now surface the socket connection to users when encountering, for example, connectivity issues.
This was already happening by default for PG and CRDB as they expect sockets through the
hostquery-arg, however our default host parsing was not picking this up for MySQL as it was expected throughsocketthere instead.Related PR: prisma/prisma#24222