Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fmt/psl): multibyte characters #4920

Closed
wants to merge 1 commit into from
Closed

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jun 14, 2024

  • Added test for missing index quick fix with multibyte characters comment

fixes prisma/language-tools#1308

@Druue Druue added this to the 5.16.0 milestone Jun 14, 2024
Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #4920 will not alter performance

Comparing fix/multibyte-characters (51eca85) with main (9959b17)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.044MiB 2.044MiB 0.000B
Postgres (gzip) 814.499KiB 814.499KiB 0.000B
Mysql 2.014MiB 2.014MiB 0.000B
Mysql (gzip) 801.027KiB 801.028KiB -1.000B
Sqlite 1.915MiB 1.915MiB 0.000B
Sqlite (gzip) 763.412KiB 763.412KiB 0.000B

@aqrln
Copy link
Member

aqrln commented Jun 16, 2024

Related: #4815

@Druue Druue closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spans and positions get shifted out of sync when schema includes multibyte characters
2 participants