Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech(fmt/psl): prep-work for further language-server support #4933

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jun 20, 2024

Added top walker
add documentation helper to Top
add name helper to FieldType
Added more positions:
ModelPosition::Name
FieldPosition::{Name,Type}
SourcePosition::Name
CompositeTypePosition

related https://github.com/prisma/team-orm/issues/1175

@Druue Druue added the PR: Improvement A PR that improves existing functionality label Jun 20, 2024
@Druue Druue added this to the 5.16.0 milestone Jun 20, 2024
@Druue Druue self-assigned this Jun 20, 2024
@Druue Druue requested a review from a team as a code owner June 20, 2024 17:20
@Druue Druue requested review from jkomyno and SevInf and removed request for a team June 20, 2024 17:20
Copy link

codspeed-hq bot commented Jun 20, 2024

CodSpeed Performance Report

Merging #4933 will not alter performance

Comparing prep/language-tools (815d114) with main (d56fe2e)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jun 20, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.043MiB 2.043MiB 92.000B
Postgres (gzip) 814.348KiB 814.516KiB -172.000B
Mysql 2.013MiB 2.013MiB 88.000B
Mysql (gzip) 800.980KiB 801.076KiB -98.000B
Sqlite 1.915MiB 1.914MiB 88.000B
Sqlite (gzip) 763.402KiB 763.373KiB 30.000B

add documentation helper to Top
add name helper to FieldType
Added more positions:
  ModelPosition::Name
  FieldPosition::{Name,Type}
  SourcePosition::Name
find_at_position doc
re-order parser-database lib
mark enum name as pub(crate)
mark source name as pub(crate)
added indexing for generatorid on schema ast
split out find_at_position
some clean-up of publicity
@Druue Druue merged commit 34ace0e into main Jun 24, 2024
206 checks passed
@Druue Druue deleted the prep/language-tools branch June 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Improvement A PR that improves existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants