Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example scripts still use 2.0.0-preview-12 in package.json #667

Closed
janpio opened this issue Oct 6, 2019 · 2 comments
Closed

Example scripts still use 2.0.0-preview-12 in package.json #667

janpio opened this issue Oct 6, 2019 · 2 comments
Assignees
Milestone

Comments

@janpio
Copy link
Contributor

janpio commented Oct 6, 2019

package.json of prisma-examples repo , prisma2 branch still use preview-12:

https://github.com/prisma/prisma-examples/blob/prisma2/javascript/script/package.json#L7
https://github.com/prisma/prisma-examples/blob/570a0dd785209644feea96ba7b1691eea0a8865b/javascript/rest-express/package.json#L15

This was harder to expected to find, as GitHub search doesn't seam to search non-master branches of repos via GitHub search.

@schickling I think this explains one of the behaviors you pinged me about from a user.

We should make sure this will not get forgotten in the future.

@janpio
Copy link
Contributor Author

janpio commented Oct 6, 2019

Could init on install maybe just write its own version number into package.json?

@janpio janpio added this to the Preview 14 milestone Oct 7, 2019
@janpio
Copy link
Contributor Author

janpio commented Oct 7, 2019

@nikolasburk fixed this in prisma/prisma-examples@926fcf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants