Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split types props of all components #173

Merged
merged 4 commits into from
Jun 3, 2024
Merged

refactor: split types props of all components #173

merged 4 commits into from
Jun 3, 2024

Conversation

LuuKhoaHoc
Copy link

@LuuKhoaHoc LuuKhoaHoc commented May 27, 2024 •
edited by spleafy
Loading

This merge separates all component prop types into separate files.

spleafy
spleafy reviewed Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@spleafy spleafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use the same comments in all prop files, to keep the consistency between files. Use "Component Props" as a comment separating the section where component props are imported.

@LuuKhoaHoc
Copy link
Author

Please, use the same comments in all prop files, to keep the consistency between files. Use "Component Props" as a comment separating the section where component props are imported.

I just completed it and I pushed, please help me check this

@spleafy spleafy merged commit 9ab3979 into prismaneui:v2 Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spleafy spleafy spleafy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuuKhoaHoc @spleafy