Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set phase2cli as ES module #19

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Set phase2cli as ES module #19

merged 3 commits into from
Apr 20, 2023

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Apr 20, 2023 •
edited by 0xjei
Loading

name: Make phase2cli an ES module
about: We need to make phase2cli an ES module to avoid errors when using the package as npm module.

Description

Currently, phase2cli wasn't working well when installing it as npm package. The problem relies on configuration. Therefore, this PR address the issue privacy-scaling-explorations/groth-p0tion#132 and converts phase2cli as ES module.

Fixes # (issue)

How Has This Been Tested?

Installation w/ npm link now works fine.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I reviewed the code of conduct and contributors' guide

@cedoor cedoor requested a review from 0xjei April 20, 2023 19:39
@cedoor cedoor temporarily deployed to p0tion-ci-environment April 20, 2023 19:39 — with GitHub Actions Inactive
@0xjei 0xjei temporarily deployed to p0tion-ci-environment April 20, 2023 19:52 — with GitHub Actions Inactive
@0xjei 0xjei temporarily deployed to p0tion-ci-environment April 20, 2023 20:10 — with GitHub Actions Inactive
@ctrlc03 ctrlc03 self-requested a review April 20, 2023 20:26
ctrlc03
ctrlc03 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedoor thanks so much for your help on this. Great work both

@ctrlc03 ctrlc03 merged commit 8827fc2 into dev Apr 20, 2023
@ctrlc03 ctrlc03 deleted the fix/npm-publish branch April 20, 2023 20:52
@0xjei 0xjei mentioned this pull request Apr 21, 2023
Closed
@0xjei 0xjei changed the title Set phase2cli as a es module Set phase2cli as ES module Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xjei 0xjei Awaiting requested review from 0xjei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedoor @ctrlc03 @0xjei