Add 10kb limit (closes #48) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Oct 18, 2022
DCtheTall
approved these changes
Oct 20, 2022
| @@ -483,7 +485,7 @@ This would ensure that cross-site cookies are hostname bound and only sent over | |||
|
|
|||
| ### Memory impact | |||
|
|
|||
| Based on Chrome data, we estimate limiting a domain to 10 cookies per-partition will satisfy ~99% of existing cross-site cookie use cases on the web today. | |||
| Based on Chrome data, we estimate that 10 cookies per-partition will satisfy ~99% of existing cross-site cookie use cases on the web today. | |||
There was a problem hiding this comment.
Kind of unrelated, but we actually have browser metrics for this that show this was an underestimate on the number of cookies domains use. Wondering if this section needs a refactor.
There was a problem hiding this comment.
Ok, do you want to do that at some point? I don't really have a good overview of those metrics.
|
I don't seem to have enough permissions on this repo to merge this PR in @DCtheTall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.