Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip other sites if the user has already completed 2FA #80

Closed
wants to merge 1 commit into from

Conversation

kcolwell
Copy link

Hi,

I couldn't figure out a way to stop privacyidea from doing 2FA when using the authproc method or "Method 2" when you are going between different sites. So, you login to site one, then do the 2FA, and then visit site two and it asks you to do the 2FA again.

Since, I couldn't figure out a way to do this, feel free to correct me if I'm wrong about this, I created a configuration option and some code.

…he 2FA process and that process hasn't expired.
@kcolwell kcolwell changed the title Skip other sites if the user has already completed 2 Skip other sites if the user has already completed 2FA Mar 10, 2020
@jp-hoehmann jp-hoehmann self-assigned this Jun 22, 2020
@jp-hoehmann jp-hoehmann added the Type: Enhancement New feature (internally/planned) or enhancement of existing feature label Jun 22, 2020
@laclaro
Copy link
Collaborator

laclaro commented Oct 2, 2020

I like the enhancement. But please think about the name of the option. What are "other related sites"? Please specify.

@NuvandaPV Do you have time to review this?

@spaceone
Copy link
Contributor

spaceone commented Dec 9, 2020

This could also be solved simpler after #91 has merged by ignoring the auth proc filter when SimpleSAML_Session::getSessionFromRequest()->getData('privacyidea:privacyidea', 'authenticated'). (aka moving this check out of the if($state['isPassive'] === true) block).

@cornelinux
Copy link
Member

@kcolwell thanks for your request. We are about the solve this in another PR, so we will close this PR shortly.

@jp-hoehmann jp-hoehmann removed their assignment Jan 2, 2021
@jp-hoehmann jp-hoehmann removed their request for review January 2, 2021 20:44
@laclaro laclaro mentioned this pull request Jan 6, 2021
@spaceone
Copy link
Contributor

spaceone commented Feb 3, 2021

This issue was mentioned here: https://groups.google.com/g/simplesamlphp/c/iaJICHisvyc/m/7p_90aogAQAJ

@laclaro laclaro mentioned this pull request Feb 10, 2021
@laclaro
Copy link
Collaborator

laclaro commented Feb 15, 2021

We implemented the SSO feature in #106. Thank you very much @kcolwell!

@laclaro laclaro closed this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature (internally/planned) or enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants