Periodically trigger database writes when write volume is insufficient #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dually. Consistency proof of concept of writing and subsequently reading an item.
ryscheng
reviewed
Mar 25, 2017
| @@ -45,6 +47,30 @@ func (r *ReadArgs) Encode(trustDomains []*TrustDomainConfig) (out EncodedReadArg | |||
| return | |||
| } | |||
|
|
|||
| // Bucket returns the bucket index that a read requests, or -1 for invalid args. | |||
| func (r *ReadArgs) Bucket() int { | |||
There was a problem hiding this comment.
This function is unused?
I'd either add some tests or remove it.
There was a problem hiding this comment.
Added the function for debugging. it was nice to be able to recover the bucket i was expecting a write to go into / a read to be of as it left the RequestManager. I'll add a test.
Minimal Command Line
Working Demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a NextEpoch RPC between leader and followers so leader can explicitly trigger a database flip.
This is gonna be a weird thing to try and get consistent order. I'm not convinced this is the 'correct' way. Instead, there should be a flag in a write that follows the same channel delivery system to signal it. The problem is how followers can identify the special write has been triggered by the leader, and isn't a malicious client RPC. This works as a placehodler until that solution is done.