Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve path correctly. #285

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Resolve path correctly. #285

merged 1 commit into from
Jan 19, 2022

Conversation

armfazh
Copy link
Member

@armfazh armfazh commented Jan 18, 2022

Fixes #282

@armfazh armfazh self-assigned this Jan 18, 2022
@armfazh
Copy link
Member Author

armfazh commented Jan 18, 2022

@warren-bank please confirm if this works ok in Windows.

@warren-bank
Copy link

warren-bank commented Jan 18, 2022 •
edited

it does.. I've been using that line of code all morning.
fwiw, this update is also included in PR #283

@ppopth ppopth merged commit 76baeea into privacypass:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppopth ppopth ppopth approved these changes

@thibmeu thibmeu Awaiting requested review from thibmeu

Assignees

@armfazh armfazh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webpack config doesn't build on Windows
3 participants
@armfazh @warren-bank @ppopth