Bugfix/hyperlink #30
Merged
Bugfix/hyperlink #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-syn
requested changes
Nov 19, 2020
There was a problem hiding this comment.
Tested on local as well. Works fine for the given example. Tried a few other combinations - table example failed.
<p>
<a href="https://en.wikipedia.org/wiki/Coffee">
<u>Coffee</u>
</a>
</p>
<h1>
<a href="https://en.wikipedia.org/wiki/Coffee">
<u>Coffee</u>
</a>
</h1>
<p>
<a href="https://en.wikipedia.org/wiki/Coffee">
<strong
><u><i>Coffee</i></u></strong
>
</a>
</p>
<table>
<tr>
<td>
<a href="https://en.wikipedia.org/wiki/Coffee">
<i>Coffee</i>
</a>
</td>
</tr>
</table>
Had to pass the docxDocumentInstance argument to the buildParagraph() inside buildTableCell(), missed it earlier. Good catch. |
amrita-syn
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28
fixed hyperlink containing document generation issue.
handled nested level hyperlinks.