Seamless-posting

[breezewish]

Commits are merged. Related privly-application PR: privly/privly-applications#274

This PR is different from #128 :

• context menu is removed because it is not working, I will added back soon. Please review this PR first.
• embeded is renamed to seamless-posting to avoid confusion, no more embeded now
• added more comments
• codes of use white Privly icon in dark background #126 are removed since it is Chrome only

[smcgregor]

This has many different content scripts. I am started to get concerned about performance. My fans have been running on high while I have been running an earlier version of this PR. We will need to evaluate it soon -- I bet there is just one part that is causing a slow down.

[smcgregor]

It looks like this message interface is deprecated

[smcgregor]

Everything looks well implemented when I look at individual functions, but I am having trouble figuring out what the responsibilities are for seamless posting in privly-applications and privly-chrome. I think you need some sort of design document that describes the separation of responsibilities. A good document would give something like:

1. The user clicks the form element on the host page
2. Privly-chrome opens (link to specific code here) an iframe, for example (link to specific code here), and positions the iframe over the form element on the host page
3. The seamless privly-app sends empty content to the content server and receives back a URL
4. The seamless privly-app messages the URL to the privly-chrome extension (link to specific code here), which puts the URL into the host page's form
5. The user types into the seamless posting iframe and the seamless posting app sends updates to the content server.
6. When the user submits the form, privly-chrome destroys the iframe (link to specific code here).

I think your method differs slightly from this.

[breezewish]

I just opened a new repository for the seamless-posting documentation: https://github.com/SummerWish/privly-seamless-posting-documentation

I think you could help me find a place to host it?

[smcgregor]

We'll either put it in the privly-organization repo or in privly-applications. I am going to open a pull requests against the current version.

[smcgregor]

Can you also open two pull requests against the develop.md? The first pull request should explain the separation of responsibilities between view/adapter/controller/model/etc. The second pull request will link to this README once it is in an official repository.

[smcgregor]

I merged this into privly-chrome's gsoc-develop and opened and issue that lists a few things we need to fix before merging into develop.

[breezewish]

Oops, sorry, I missed your comments which is posted a week ago. I will solve them.

[breezewish]

Latest commits fixed #132

[smcgregor]

I think I should have closed this pull request when I merged to gsoc-develop. Can you please open a new PR there?

[breezewish]

Moved to #133