-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
NOTICE: the Privly button has not been refactored to the latest message layer
This has many different content scripts. I am started to get concerned about performance. My fans have been running on high while I have been running an earlier version of this PR. We will need to evaluate it soon -- I bet there is just one part that is causing a slow down. |
// since we want to send to a specific target. | ||
// context_messenger doesn't support specify | ||
// target now. | ||
chrome.tabs.sendRequest(tab.id, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this message interface is deprecated
Everything looks well implemented when I look at individual functions, but I am having trouble figuring out what the responsibilities are for seamless posting in privly-applications and privly-chrome. I think you need some sort of design document that describes the separation of responsibilities. A good document would give something like:
I think your method differs slightly from this. |
I just opened a new repository for the seamless-posting documentation: https://github.com/SummerWish/privly-seamless-posting-documentation I think you could help me find a place to host it? |
We'll either put it in the privly-organization repo or in privly-applications. I am going to open a pull requests against the current version. |
Can you also open two pull requests against the develop.md? The first pull request should explain the separation of responsibilities between view/adapter/controller/model/etc. The second pull request will link to this README once it is in an official repository. |
I merged this into privly-chrome's gsoc-develop and opened and issue that lists a few things we need to fix before merging into develop. |
Oops, sorry, I missed your comments which is posted a week ago. I will solve them. |
Latest commits fixed #132 |
I think I should have closed this pull request when I merged to gsoc-develop. Can you please open a new PR there? |
Moved to #133 |
Commits are merged. Related privly-application PR: privly/privly-applications#274
This PR is different from #128 :
embeded
is renamed toseamless-posting
to avoid confusion, no moreembeded
now