feat: add ability to clear select state with clearable props #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the PrivyID Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 227 227
Lines 21336 21341 +5
Branches 1745 1746 +1
=========================================
+ Hits 21336 21341 +5
☔ View full report in Codecov by Sentry. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adenvt
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi creator,
I hope you're well! I've created this pull request to add clearable props in the Select component, the purpose is to give developers an option to make their select component have the ability to clear the state.
Changes:
Testing:
I've performed thorough testing to ensure the new functionality works as expected:
Notes:
I've updated the codebase documentation and comments to reflect the changes accurately.
Please review this pull request when you have time. Your feedback is valuable, and I'm open to making any necessary adjustments.
Thank you!
Best regards,
Rendy Andika