Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Introduction to iOS] Project 2 - Review my app #1

Open
priyankaavj opened this issue Sep 18, 2014 · 1 comment
Open

[Introduction to iOS] Project 2 - Review my app #1

priyankaavj opened this issue Sep 18, 2014 · 1 comment

Comments

@priyankaavj
Copy link
Owner

My app is complete, please review /cc @thecodepath

@timothy1ee
Copy link

👍 nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. A few notes after checking out the code:

  • Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
  • Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
  • You've probably noticed that the view controller files are getting to be pretty long. As the class progresses, we'll learn to start refactoring things out of that class. For example, all the networking and model deserialization code will go into the model classes. All the view manipulation and templating code will go into custom view classes.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants