Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests subpackages from resulting Python wheel #188

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

daa
Copy link
Contributor

@daa daa commented Jan 10, 2020

Currently uplink wheel contains tests subpackages but shouldn't. It happens because exclude argument to find_packages() function makes setuptools to exclude packages enumerated in that argument but not their subpackages and thus tests.unit and tests.integration appear in the resulting wheel.

Changes proposed in this pull request:

  • Exclude tests.* subpackages together with tests.

Attention: @prkumar

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #188   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines        2322   2322           
  Branches      173    173           
=====================================
  Hits         2322   2322

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61edb2...d5caa60. Read the comment docs.

@prkumar prkumar self-requested a review January 10, 2020 17:32
@prkumar prkumar modified the milestones: v1.0.0, v0.10.0 Jan 10, 2020
Copy link
Owner

@prkumar prkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch, @daa! Thanks for fixing this.

@prkumar prkumar merged commit d14509a into prkumar:master Jan 10, 2020
@daa daa deleted the exclude-tests-subpackages-from-wheel branch January 10, 2020 17:54
@prkumar prkumar mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants