Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for "@asyncio.coroutine" usage in library #248

Merged
merged 7 commits into from
Jan 22, 2022

Conversation

prkumar
Copy link
Owner

@prkumar prkumar commented Jan 18, 2022

This PR removes @asyncio.coroutine usage in Uplink.

#203

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #248 (fc0ce44) into master (5158457) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2475      2464   -11     
  Branches       358       358           
=========================================
- Hits          2475      2464   -11     
Impacted Files Coverage Δ
uplink/clients/aiohttp_.py 100.00% <100.00%> (ø)
uplink/clients/io/asyncio_strategy.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5158457...fc0ce44. Read the comment docs.

@prkumar
Copy link
Owner Author

prkumar commented Jan 18, 2022

Still need to remove usage of "asyncio.coroutine" in unit test. This will require us to separate tests for the AiohttpClient from other clients. We will also need to prevent tests for AiohttpClient and AsyncioStrategy from running when python version is 2.7

@prkumar
Copy link
Owner Author

prkumar commented Jan 18, 2022

Pytest documentation suggests that we can configure pytest to ignore certain test files/directories based on python version: https://docs.pytest.org/en/6.2.x/example/pythoncollection.html#customizing-test-collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant