Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geologic Surface Creation #19

Open
2 of 3 tasks
chris-traxler opened this issue Mar 9, 2021 · 7 comments
Open
2 of 3 tasks

Geologic Surface Creation #19

chris-traxler opened this issue Mar 9, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@chris-traxler
Copy link
Collaborator

chris-traxler commented Mar 9, 2021

Create a surface between polylines used for delineation of surface features. This can also be used in tunnel monitoring to create surfaces between geologic interpretations of more tunnel faces. Task separation:

  • Connect endpoints of polylines and triangulate in discrete steps
  • Add as separate object group into GUI
  • Adjust colour and transparency in GUI

Requirement P3D-M012

@chris-traxler chris-traxler added the enhancement New feature or request label Mar 9, 2021
@LauraFritz14 LauraFritz14 self-assigned this Apr 8, 2021
@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented May 3, 2021

Branch: develop/features/geologicSurfaceCreation
Commit 62436cf
Testdata: file://euclid.vrvis.lan/InOut/PRo3D/TunnelFaceSequence.7z

Here is my scene file: Z:\projects\20-ExoMars_PanCam_3D_Vision_2021\data\GeologicSurfaceCreation

selection

To create a new geologic surface select two annotations via multiselection (click on the cube in front of the annotations name) in the Annotations tab.

mesh

Then push the +-button (A) in top of the GeologicSurfaces tab to get an new geologic surface in the 3d view and in the listing (B).
The listing (right) shows all meshes in the scene. Under the mesh's name is a little menu:

  • FlyTo: triggers a FlyTo animation
  • Toggle Visible: toggles the mesh visible/invisible
  • Remove: removes the mesh from the scene

You can select a mesh by clicking on it's name, which turns the color to green. Then you can see the mesh's properties in the Properties panel below:

  • Name: the name in the listing (press enter)
  • Visible: toggles the mesh visible/invisible
  • Outline thickness: the outline thickness
  • Transparency: the transparency of the surface
  • Color: the color of the surface
  • Invert meshing: if your surface looks like this:
    invert

known rendering issue:

issue

The geologic surfaces are rendered in drawing order.

@chris-traxler
Copy link
Collaborator Author

Everything works fine as described above by @LauraFritz14. The current mesh creation method by connecting points of two polylines works well enough and can be included in the next release. It is hard to avoid artefacts that result from two polylines that do not match ideally. Artefacts are then visible when increasing the transparency.

Geologic Surfaces 2

I suggest to drop the subtask "Connect endpoints of polylines and triangulate in discrete steps" because it would not improve the situation of badly matching polylines.

@chris-traxler
Copy link
Collaborator Author

There is a small usability issue. When navigating to a geologic surface, PRo3D assumes a view that corresponds to the polyline that was selected second. So the surface is viewed edge on.

PRo3D-GeologicSurfaces.mp4

@LauraFritz14
Copy link
Collaborator

Commit 5eeb3f1

hp

Added "Set Homeposition" button to properties panel. You can set the current camera view as FlyTo view for the selected geologic surface to solve the problem described by @chris-traxler above.

@chris-traxler
Copy link
Collaborator Author

I successfuly tested the "Set Homeposition" button for different geologic surfaces and for different viewpoints.

@ThomasOrtner
Copy link
Collaborator

Untitled.Project.mp4

I tested the geological surface and I have to remarks

  1. there are numerical issues with Martian data, tested it with a Shaler Scene
  2. there should be some hints on how to create a geological surface in the respective tab when nothing is selected, e.g. nothing is selected - "(multi) select two annotations to connect", one is selected - "1 of 2 annotations selected", ...

@ThomasOrtner ThomasOrtner reopened this Jul 13, 2021
@ThomasOrtner
Copy link
Collaborator

is this solved in any newer version? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants