Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading real images when generating semi-synthetic images #907

Closed
jeff-regier opened this issue Aug 1, 2023 · 0 comments · Fixed by #927
Closed

Avoid loading real images when generating semi-synthetic images #907

jeff-regier opened this issue Aug 1, 2023 · 0 comments · Fixed by #927
Assignees
@zhixiangteoh

Comments

@jeff-regier
Copy link
Contributor

Survey subclasses should have a binary variable that controls whether images or just metadata are loaded. We only need to load metadata when generating semi-synthetic images.
zhixiangteoh added a commit that referenced this issue Aug 17, 2023
@zhixiangteoh
Don't load real images when simulating data
56ceb51 
Added binary variable `load_image_data` that conditionally loads real
survey image data only when it is needed (e.g., in predict).

NOTE: DES image data is currently loaded for DECaLS data simulation
because the parameter `sig1` used for DECaLS coadd PSF simulation uses
this image data for its computation. This dependence likely can be
easily removed.

Fixes #907.
@zhixiangteoh zhixiangteoh mentioned this issue Aug 17, 2023
Merged
zhixiangteoh added a commit that referenced this issue Aug 17, 2023
@zhixiangteoh
Don't load real images when simulating data
84cf202 
Added binary variable `load_image_data` that conditionally loads real
survey image data only when it is needed (e.g., in predict).

NOTE: DES image data is currently loaded for DECaLS data simulation
because the parameter `sig1` used for DECaLS coadd PSF simulation uses
this image data for its computation. This dependence likely can be
easily removed.

Fixes #907.
zhixiangteoh added a commit that referenced this issue Aug 17, 2023
@zhixiangteoh
Don't load real images when simulating data
9f7941a 
Added binary variable `load_image_data` that conditionally loads real
survey image data only when it is needed (e.g., in predict).

NOTE: DES image data is currently loaded for DECaLS data simulation
because the parameter `sig1` used for DECaLS coadd PSF simulation uses
this image data for its computation. This dependence likely can be
easily removed.

Fixes #907.
jeff-regier pushed a commit that referenced this issue Aug 18, 2023
@zhixiangteoh
Don't load real images when simulating data (#927)
9800ddf 
* Don't load real images when simulating data

Added binary variable `load_image_data` that conditionally loads real
survey image data only when it is needed (e.g., in predict).

NOTE: DES image data is currently loaded for DECaLS data simulation
because the parameter `sig1` used for DECaLS coadd PSF simulation uses
this image data for its computation. This dependence likely can be
easily removed.

Fixes #907.

* Fix tests

* Ensure images downloaded for required metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhixiangteoh zhixiangteoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't load real images when simulating data prob-ml/bliss
2 participants
@jeff-regier @zhixiangteoh