Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yd/add plot #1020

Merged
merged 16 commits into from
Jun 21, 2024
Merged

Yd/add plot #1020

merged 16 commits into from
Jun 21, 2024

Conversation

YicunDuanUMich
Copy link
Collaborator

  • refactor notebooks
  • add new metrics
  • add flux error plot

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (edbe0ea) to head (f130668).

Files Patch % Lines
bliss/catalog.py 71.42% 2 Missing ⚠️
bliss/surveys/dc2.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
- Coverage   91.44%   91.41%   -0.04%     
==========================================
  Files          23       23              
  Lines        3133     3144      +11     
==========================================
+ Hits         2865     2874       +9     
- Misses        268      270       +2     
Flag Coverage Δ
unittests 91.41% <85.18%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please merge once the tests pass

@YicunDuanUMich YicunDuanUMich merged commit 7f5905d into master Jun 21, 2024
3 checks passed
@YicunDuanUMich YicunDuanUMich deleted the yd/add_plot branch June 21, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants