Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular update #1047

Merged
merged 21 commits into from
Jul 24, 2024
Merged

Regular update #1047

merged 21 commits into from
Jul 24, 2024

Conversation

YicunDuanUMich
Copy link
Collaborator

  • add ellipticity estimation
  • add notebooks to show error wrt blendedness

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 87.89809% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (d84e937) to head (1f2900b).

Files Patch % Lines
bliss/catalog.py 59.45% 15 Missing ⚠️
bliss/encoder/metrics.py 94.28% 2 Missing ⚠️
bliss/encoder/variational_dist.py 95.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   80.91%   81.00%   +0.08%     
==========================================
  Files          23       23              
  Lines        2819     2874      +55     
==========================================
+ Hits         2281     2328      +47     
- Misses        538      546       +8     
Flag Coverage Δ
unittests 81.00% <87.89%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyasc30 shreyasc30 mentioned this pull request Jul 22, 2024
@YicunDuanUMich
Copy link
Collaborator Author

ready for merge

@YicunDuanUMich YicunDuanUMich marked this pull request as draft July 23, 2024 17:48
@YicunDuanUMich
Copy link
Collaborator Author

Because our bin cutoffs can be blendedness, I don't change the bin_cutoffs, bin_type and some variables like cur_batch_true_bin_meas.

@YicunDuanUMich YicunDuanUMich marked this pull request as ready for review July 23, 2024 19:33
.flake8 Outdated Show resolved Hide resolved
bliss/catalog.py Outdated Show resolved Hide resolved
bliss/catalog.py Show resolved Hide resolved
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions!

@jeff-regier jeff-regier merged commit 2cefde4 into master Jul 24, 2024
3 checks passed
@jeff-regier jeff-regier deleted the yd/dc2_cataloging_07-15 branch July 24, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants