Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak lensing DC2 updates #1061

Merged
merged 30 commits into from
Aug 19, 2024
Merged

Conversation

timwhite0
Copy link
Collaborator

A few recent updates to the weak lensing case study:

  • New version of to_toy_catalog in LensingDC2DataModule that circumvents n_sources entirely.
  • Reorganized notebooks.
  • We now compute average ellipticity per tile as a baseline estimator for shear.
  • New strategy for loading in the DC2 catalog. Previously we were using all ~128 million galaxies from CosmoDC2, but we realized that we only want to use the ~10 million from the truth table (more specifically, the truth columns from the object_with_truth_match table).
  • Simulator is now up-to-date with master. Currently uses the SDSS-like decoder from master along with a toy lensing prior.

timwhite0 and others added 28 commits August 13, 2024 10:02
…n script (#1058)

* Batched to_tile_catalog (#1057)

batched to_tile_catalog

Co-authored-by: Yicun Duan <pduan@deeplearning-01.stat.lsa.umich.edu>

* Add lensed ellipticities to tile catalog; ellipticity vs shear notebook

* Organize notebooks

* Script to generate DC2 pkl file with shear, conv, ellipticity, redshift

* Use avg ellipticity as baseline shear estimator; fix MSE bugs; remove baseline convergence estimator

* Try-except block in cached_dataset

* Update catalog and splits paths in config, update plots dir name

---------

Co-authored-by: Yicun Duan <144750316+YicunDuanUMich@users.noreply.github.com>
Co-authored-by: Yicun Duan <pduan@deeplearning-01.stat.lsa.umich.edu>
…ob-ml/bliss into sc/lensing_refactor_catalog_n_sources
…ob-ml/bliss into sc/lensing_refactor_catalog_n_sources
…ob-ml/bliss into sc/lensing_refactor_catalog_n_sources
…ob-ml/bliss into sc/lensing_refactor_catalog_n_sources
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (bc88cfe) to head (881a110).
Report is 1 commits behind head on master.

Files Patch % Lines
bliss/encoder/variational_dist.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   80.76%   80.73%   -0.04%     
==========================================
  Files          23       23              
  Lines        3068     3073       +5     
==========================================
+ Hits         2478     2481       +3     
- Misses        590      592       +2     
Flag Coverage Δ
unittests 80.73% <60.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeff-regier jeff-regier merged commit 41d09e1 into master Aug 19, 2024
3 checks passed
@jeff-regier jeff-regier deleted the sc/lensing_refactor_catalog_n_sources branch August 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants