Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak lensing simulator #1071

Merged
merged 14 commits into from
Sep 15, 2024
Merged

Weak lensing simulator #1071

merged 14 commits into from
Sep 15, 2024

Conversation

timwhite0
Copy link
Collaborator

This PR gets our weak lensing simulator up-to-date with master.

Changes to the weak lensing case study:

  • In LensingPrior, shear and convergence are now constant across the images. The current config uses large shear and convergence.
  • Two notebooks: One demonstrates the robustness of shear two-point correlation functions to different noise distributions, and the other analytically derives the effects of weak lensing on galaxy shapes.

Changes to the main BLISS decoder:

  • We add a helper function to render_galaxy so that we don't have to repeat code in the lensing subclass of the decoder. Note that we can't just do super().render_galaxy() in the lensing decoder because we don't want to convolve the galaxy with the PSF until after shear and convergence are applied.
  • We allow ourselves to circumvent sampling the SDSS background in render_image, as the SDSS frame from which the background is sampled by default is smaller than the images we want for our case study.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.17%. Comparing base (a1c981b) to head (c02ee4d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
bliss/simulator/decoder.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1071   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files          22       22           
  Lines        3072     3077    +5     
=======================================
+ Hits         2340     2344    +4     
- Misses        732      733    +1     
Flag Coverage Δ
unittests 76.17% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeff-regier jeff-regier merged commit 0907a16 into master Sep 15, 2024
3 checks passed
@jeff-regier jeff-regier deleted the tw/weak_lensing branch September 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants