-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weak lensing simulator #1071
Merged
Merged
Weak lensing simulator #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 22 22
Lines 3072 3077 +5
=======================================
+ Hits 2340 2344 +4
- Misses 732 733 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jeff-regier
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets our weak lensing simulator up-to-date with master.
Changes to the weak lensing case study:
LensingPrior
, shear and convergence are now constant across the images. The current config uses large shear and convergence.Changes to the main BLISS decoder:
render_galaxy
so that we don't have to repeat code in the lensing subclass of the decoder. Note that we can't just dosuper().render_galaxy()
in the lensing decoder because we don't want to convolve the galaxy with the PSF until after shear and convergence are applied.render_image
, as the SDSS frame from which the background is sampled by default is smaller than the images we want for our case study.