Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete intermediate tensors in BinaryEncoder forward #440

Closed
wants to merge 1 commit into from

Conversation

dereklhansen
Copy link
Contributor

This fixes an out-of-memory issue in the BinaryEncoder forward when training on GPU

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #440 (5257659) into master (957d5ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   93.65%   93.66%           
=======================================
  Files          20       20           
  Lines        2932     2934    +2     
=======================================
+ Hits         2746     2748    +2     
  Misses        186      186           
Flag Coverage Δ
unittests 93.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bliss/models/binary.py 99.14% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 957d5ce...5257659. Read the comment docs.

@jeff-regier jeff-regier deleted the delete-intermediate-in-binary branch August 5, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant