Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mallory/coadd #649

Closed
wants to merge 35 commits into from
Closed

Mallory/coadd #649

wants to merge 35 commits into from

Conversation

wangmallory
Copy link
Contributor

This request has

  • coadd_decoder: CoaddUniformGalsimGalaxiesPrior, CoaddSingleGalaxyDecoder, CoaddGalsimBlends, FullCatalogDecoder
  • example_coadd_decoder: runs all the functions in coadd_decoder and uses real example
  • config file
  • test_coadd_decoder

ismael-mendoza and others added 30 commits June 18, 2022 08:35
@ismael-mendoza
Im/fix max tile sources (#642)
14eef1a 
* fix error in gpu test

* make it explicit when exceeding number of sources in tile

* fix flake8

* add test for catalog functionality

* imported by mistake
@wangmallory
adding align_single_exposures function, snr function and galsim_galax…
5e6273c 
…y dataset
@wangmallory
add align_single_exposures, snr functions and galsim_galaxies dataset…
1579a9f 
… -- incomplete
@wangmallory
update config
b022362
@wangmallory
update coadd_decoder and add test_notebook
7c1aacd
@wangmallory
update signal_noise_ratio
deeb6cc
@wangmallory
update render_galaxy in coadd_decoder, still need to fix render_catalog
6c48693
@wangmallory
fixed render_catalog
2533cae
@wangmallory
update notebook
2d2ccac
@wangmallory
add cropping to align_single_exposures
0a13726
@wangmallory
add crop to align_single_exposures and unit test
6a0f3cd
@wangmallory
fix align_single_exposure to take img0 and images
d7e9b61
@wangmallory
fix align_single_exposures to take img0 and images
948871a
@wangmallory
update align, snr, and galsimblend
e26bea5
@wangmallory
update with changes from mallory/align branch
c8b0302
@wangmallory
update config file
8d9e7ee
@wangmallory
add config
c12d4f7
@wangmallory
add config
148ab8e
@wangmallory
update config
3c6409e
@wangmallory
change directory for config
f2d47a8
@wangmallory
update config file
dc2025c
@wangmallory
update coadd_decoder
7669366
@wangmallory
push notebook
ba3e61c
@wangmallory
fix bugs in coadd_decoder and add example notebook
0ed9300
@wangmallory
formatting updates
150ec94
@wangmallory
fixed bugs in coadd_decoder and added to example
7870b48
@wangmallory
update test_notebook
fa0f472
@wangmallory
fix coadd_decoder
b8a2ad7
@wangmallory
adding test_coadd_decoder
4a0ad66
@wangmallory
formatting
6417286
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #649 (5c48b5a) into master (fbaf59a) will decrease coverage by 1.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   93.08%   91.69%   -1.40%     
==========================================
  Files          21       21              
  Lines        2966     3022      +56     
==========================================
+ Hits         2761     2771      +10     
- Misses        205      251      +46
Flag Coverage Δ
unittests 91.69% <100.00%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bliss/catalog.py 84.12% <100.00%> (-10.68%) ⬇️
bliss/datasets/galsim_galaxies.py 97.26% <100.00%> (ø)
bliss/inference.py 93.58% <0.00%> (-1.78%) ⬇️
bliss/datasets/sdss.py 98.86% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wangmallory
Copy link
Contributor Author

wangmallory commented Jul 29, 2022 •
edited
Loading

Closing this request. Will replace with a new branch mallory/coadd2

@ismael-mendoza ismael-mendoza deleted the mallory/coadd branch August 1, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismael-mendoza ismael-mendoza Awaiting requested review from ismael-mendoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangmallory @ismael-mendoza