Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully convolutional detection encoder #718

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

jeff-regier
Copy link
Contributor

@jeff-regier jeff-regier commented Mar 8, 2023

This PR adds a case study that demonstrates a new fully convolutional encoder architecture. Because it doesn't form padded tiles, this encoder is 4 times than our current detection encoder (>6 training iterations per second, whereas the old detection encoder performed about 1.5 iterations / second). The graphs below suggest that it is also more accurate. The old encoder, which was trained for 24 hours, appears in grey. The new encoder, which was trained for 6 hours, appears in red.

Screenshot 2023-03-08 at 10 04 28 AM

Screenshot 2023-03-08 at 10 04 37 AM

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #718 (56c08d0) into master (6963103) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 56c08d0 differs from pull request most recent head e98f7bf. Consider uploading reports for the commit e98f7bf to get more accurate results

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   83.82%   83.84%   +0.02%     
==========================================
  Files          27       27              
  Lines        3839     3838       -1     
==========================================
  Hits         3218     3218              
+ Misses        621      620       -1     
Flag Coverage Δ
unittests 83.84% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bliss/train.py 57.77% <100.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeff-regier for this PR. In terms of changes, there is only very minor ones in one of the config files. The other comments are just questions which you can feel free to delay until the meeting today.

bliss/train.py Show resolved Hide resolved
case_studies/new_detection_encoder/config/config.yaml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
case_studies/sdss_galaxies_vae/config/config.yaml Outdated Show resolved Hide resolved
case_studies/sdss_galaxies/config/config.yaml Outdated Show resolved Hide resolved
case_studies/new_detection_encoder/main.py Outdated Show resolved Hide resolved
case_studies/new_detection_encoder/main.py Show resolved Hide resolved
@ismael-mendoza ismael-mendoza self-requested a review March 10, 2023 01:00
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-regier I think you can merge now. Feel free to delete the checkerboard later or not depending on your experiments.

@jeff-regier
Copy link
Contributor Author

The checkerboard wasn't helpful/necessary after all. Deleted. I fixed the config files too.

@jeff-regier
Copy link
Contributor Author

I improved the learning rate schedule for the new architecture. (Dropped one of the milestones.) Here are results for the old (grey) and new (red) encoders, both trained for 24 hours. The new encoder finishes 4x as many iterations during that time, but even per iteration it appears to have an edge.
Screenshot 2023-03-10 at 9 39 22 AM

Screenshot 2023-03-10 at 9 39 57 AM

@jeff-regier jeff-regier merged commit f191de0 into master Mar 10, 2023
@jeff-regier jeff-regier deleted the jr/new_detection_encoder branch March 10, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants