-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spring cleaning #720
Merged
Merged
spring cleaning #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slen with tiles_to_crop
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=========================================
Coverage ? 70.70%
=========================================
Files ? 13
Lines ? 1379
Branches ? 0
=========================================
Hits ? 975
Misses ? 404
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and simplifying the code base in preparation for summer
closes #687 by removing the
GalaxyDecoder
closes #697, not by adding a
StarEncoder
class, but by removing theGalaxyEncoder
-- there's just one encoder now.closes #690 and #691 by removing support for more than one detection per tile -- overlapping tiles are a cleaner way to deal with multiple nearby objects, if we need this functionality
closes #696 because the galaxy parameters no longer depend on the location parameters in the variational distribution, as a consequence of merging the various encoders into a single encoder.
closes #698 by having
variational_mode
take the output ofencoder_batch
as its inputcloses #715 (I think) through the introduction of a
render_images
function, which renders full batches of images (Note thatFullCatalogDecoder
is now namedImageDecoder
, and the formerImageDecoder
has been removed)