Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor simulator (prior and decoder) #734

Merged
merged 12 commits into from
Apr 25, 2023
Merged

refactor simulator (prior and decoder) #734

merged 12 commits into from
Apr 25, 2023

Conversation

jeff-regier
Copy link
Contributor

@jeff-regier jeff-regier commented Apr 25, 2023

This PR gets rid of the inheritance structure in the simulator, which was excessive.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #734 (3b7c24c) into master (0452bdb) will decrease coverage by 0.97%.
The diff coverage is 98.64%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   70.70%   69.73%   -0.97%     
==========================================
  Files          13       13              
  Lines        1379     1315      -64     
==========================================
- Hits          975      917      -58     
+ Misses        404      398       -6     
Flag Coverage Δ
unittests 69.73% <98.64%> (-0.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bliss/simulator/decoder.py 99.04% <95.00%> (-0.18%) ⬇️
bliss/encoder.py 96.99% <100.00%> (-0.03%) ⬇️
bliss/simulator/prior.py 100.00% <100.00%> (+5.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeff-regier jeff-regier merged commit c5056d0 into master Apr 25, 2023
@jeff-regier jeff-regier deleted the jr/nms branch April 25, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant