bug fix and remove risky cropping code #748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
+ Coverage 70.06% 71.36% +1.30%
==========================================
Files 13 13
Lines 1326 1299 -27
==========================================
- Hits 929 927 -2
+ Misses 397 372 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good to me. The Also fwiw, the number of sources is also a little bit better with the new model - 197 predicted compared to 200 in SDSS. |
|
The value for flux_diff / flux_sum is still around 0.15 using 100 as cut off for the fluxes value in the reconstruction image. I use [160:320] cropped sdss image because there is no fluxes bigger than 100 in [0:160]: True image (image minus background) Reconstructed image But the reconstructed image looks good to me. |
* don't crop FullCatalogs because it's ambigous where doing so rescales the coordinates * fixed bad bug that I introduced rently * added newly pretrained sdss encoder * reference sdss.pt instead of crowded_field.pt
This PR fixes the star flux bug and includes a newly pretrained
sdss.ptmodel indata/pretrained_models/.@aakashdp6548 Please lmk if this fixes the issue with the test you are writing.
@XinyueLi1012 Please lmk if you can increase the threshold in your test following this PR.