Fix metrics bug when 0 sources #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 88.41% 88.48% +0.06%
==========================================
Files 14 14
Lines 1252 1259 +7
==========================================
+ Hits 1107 1114 +7
Misses 145 145
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeff-regier
force-pushed
the
752-fix-metrics-bug
branch
from
816a2f2
to
b2f5c46
Compare
jeff-regier
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752. Metrics didn't correctly handle the case when either the number of true or estimated sources in a batch was 0, and would raise an exception. Now we manually check before calling
match_by_locsand increment false positives / false negatives accordingly. I don't think there's any good way of measuring "average distance" in this case since there are no matches to compute the distance between, so that only gets updated in batches that have both true and estimated sources.Also added
test_no_sourcesin test_metrics that checks this functionality.