Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple generate config from training #755

Merged
merged 2 commits into from
May 11, 2023
Merged

Decouple generate config from training #755

merged 2 commits into from
May 11, 2023

Conversation

zhixiangteoh
Copy link
Contributor

So that cfg.cached_simulator is only needed/used for training, and cfg.generate (with cfg.simulator) defines how data is generated at generate step.

jeff-regier
jeff-regier reviewed May 11, 2023
View reviewed changes
bliss/generate.py Outdated Show resolved Hide resolved
jeff-regier
jeff-regier approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge once checks are passing and comments are addressed

@zhixiangteoh zhixiangteoh merged commit 756092a into master May 11, 2023
@zhixiangteoh zhixiangteoh deleted the decouple-gen-train-configs branch May 11, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakashdp6548 aakashdp6548 aakashdp6548 left review comments

@jeff-regier jeff-regier jeff-regier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhixiangteoh @jeff-regier @aakashdp6548