Add early stopping #767
Merged
Add early stopping #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 88.75% 88.90% +0.15%
==========================================
Files 14 14
Lines 1254 1271 +17
==========================================
+ Hits 1113 1130 +17
Misses 141 141
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhixiangteoh
suggested changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to stop training early if validation loss hasn't decreased for a set number of epochs. This is configurable using the
enable_early_stoppingandpatienceflags inconfig.trainer.I removed the
min_epochsflag from trainer because that overrides early stopping. I also suppressed a pylint warning for too-many-statements intrain- we should maybe consider factoring some of the stuff that isn't directly related to training, like loading best weights, into a separate function.