Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tests on gpu #768

Merged
merged 1 commit into from
May 16, 2023
Merged

fixed tests on gpu #768

merged 1 commit into from
May 16, 2023

Conversation

jeff-regier
Copy link
Contributor

@jeff-regier jeff-regier commented May 16, 2023

It looks like some data structures weren't moved over to whatever device the encoder is on. As a result, though pytest passes, pytest --gpu wasn't passing before this PR.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@da5d581). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #768   +/-   ##
=========================================
  Coverage          ?   88.88%           
=========================================
  Files             ?       14           
  Lines             ?     1269           
  Branches          ?        0           
=========================================
  Hits              ?     1128           
  Misses            ?      141           
  Partials          ?        0           
Flag Coverage Δ
unittests 88.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeff-regier jeff-regier merged commit 00e3bb7 into master May 16, 2023
@jeff-regier jeff-regier deleted the jr/fix-gpu-tests branch May 16, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant