-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce predict tests #877
Reduce predict tests #877
Conversation
Remove tests that test mostly already-tested code. Fixes #876.
829dd99
to
4907a7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 21 21
Lines 2256 2256
=======================================
Hits 2158 2158
Misses 98 98
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks like the tests are still taking > 20 minutes, with ~12 minutes consumed Could we add some (optional) configuration settings to process just subimages within bricks/fields. i.e., for each brick/field, process just on a region (perhaps an 80x80-pixel box) specified in the config? This could be useful for users too, not just for testing. Users may only be interested in a particular bounding box.
|
`predict.align` analyzed by kernprof to take ~40% runtime of predict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an improvement, but I still hope we can get runtime below 10 minutes--see comment above.
Predictions are already being done on 160x160 pixel box ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Test finish in 8 minutes with no drop in test coverage.
Remove tests that test mostly already-tested code.
Fixes #876.