Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#829 input transforms #878

Merged
merged 11 commits into from
Aug 4, 2023
Merged

#829 input transforms #878

merged 11 commits into from
Aug 4, 2023

Conversation

sawanp813
Copy link
Collaborator

This PR tracks #829 and #811 to find a combination of input transformations that optimizes BLISS performance across any form of semi-synthetic SDSS image, particularly with a focus on images containing bright light sources.

@jeff-regier jeff-regier linked an issue Jul 20, 2023 that may be closed by this pull request
5 tasks
@jeff-regier jeff-regier added this to the version 0.3 milestone Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #878 (7660640) into master (8a5d252) will increase coverage by 0.12%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   95.97%   96.10%   +0.12%     
==========================================
  Files          25       25              
  Lines        2859     2872      +13     
==========================================
+ Hits         2744     2760      +16     
+ Misses        115      112       -3     
Flag Coverage Δ
unittests 96.10% <95.65%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
bliss/encoder.py 97.50% <85.71%> (+0.51%) ⬆️
bliss/transforms.py 86.95% <100.00%> (+32.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeff-regier jeff-regier marked this pull request as ready for review August 4, 2023 16:17
@jeff-regier jeff-regier marked this pull request as draft August 4, 2023 16:18
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sawanp813 sawanp813 marked this pull request as ready for review August 4, 2023 16:29
bliss/transforms.py Outdated Show resolved Hide resolved
@sawanp813 sawanp813 merged commit 6983a5e into master Aug 4, 2023
3 checks passed
@sawanp813 sawanp813 deleted the 829_input_transforms branch August 4, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image transformations for improved encoding
2 participants