Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes #916

Merged
merged 8 commits into from
Aug 9, 2023
Merged

Miscellaneous fixes #916

merged 8 commits into from
Aug 9, 2023

Conversation

aakashdp6548
Copy link
Collaborator

@aakashdp6548 aakashdp6548 commented Aug 8, 2023

Fixes #894 and #763. Also fixes the region encoder bug mentioned in #915.

@jeff-regier
Copy link
Contributor

You mean #894, right? (#890 is a PR, not an issue)

Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixes

@aakashdp6548
Copy link
Collaborator Author

Oops, yes I meant 894. Thanks!

@aakashdp6548 aakashdp6548 mentioned this pull request Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #916 (5bfb94e) into master (417d4c1) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   95.82%   95.79%   -0.04%     
==========================================
  Files          25       25              
  Lines        3067     3066       -1     
==========================================
- Hits         2939     2937       -2     
- Misses        128      129       +1     
Flag Coverage Δ
unittests 95.79% <88.88%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
bliss/api.py 87.17% <ø> (ø)
bliss/encoder.py 96.98% <66.66%> (-0.49%) ⬇️
bliss/predict.py 99.52% <100.00%> (-0.01%) ⬇️
bliss/simulator/decoder.py 100.00% <100.00%> (ø)
bliss/unconstrained_dists.py 87.67% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aakashdp6548 aakashdp6548 merged commit f07fcf7 into master Aug 9, 2023
3 checks passed
@aakashdp6548 aakashdp6548 deleted the aakash/misc branch August 9, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants