-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more acquisition functions for quad
#758
Merged
mmahsereci
merged 25 commits into
probabilistic-numerics:main
from
mmahsereci:mm-quad-mi
Feb 10, 2023
Merged
Some more acquisition functions for quad
#758
mmahsereci
merged 25 commits into
probabilistic-numerics:main
from
mmahsereci:mm-quad-mi
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 91.10% 91.16% +0.05%
==========================================
Files 213 215 +2
Lines 7924 7977 +53
Branches 1014 1015 +1
==========================================
+ Hits 7219 7272 +53
Misses 479 479
Partials 226 226
|
tskarvone
reviewed
Feb 10, 2023
src/probnum/quad/solvers/acquisition_functions/_integral_variance_reduction.py
Outdated
Show resolved
Hide resolved
tskarvone
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
This PR introduces the mutual information acquisition function and the integral variance acquisition function to the
quad
package.Detailed Description
RandomMaxAcquisitionPolicy
orMaxAcquisitionPolicy
(for the latter seeMaxAcquisitionPolicy
forquad
#757 ), hence there are 4 new policies in total.predict_integrand
method in the belief updater as such a prediction is needed for more than one acquisition function.RandomMaxAcquisitionPolicy
orMaxAcquisitionPolicy
are renamed such that they are applicable to all acquisition functions, e.g.,us_rand_n_candidates
is renamed ton_candidates
.Should be reviewed after #757 is merged as it branches off of it (and currently has both diffs displaying).Related Issues
Closes #...