fix: iterator on empty trace

probcomp · Oct 20, 2023 · b6d5a7e · b6d5a7e
1 parent 4534e1c
commit b6d5a7e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/gen/dynamic/trace.cljc b/src/gen/dynamic/trace.cljc
@@ -10,7 +10,7 @@
      (:require-macros [gen.dynamic.trace]))
   #?(:clj
      (:import
-      (clojure.lang Associative IFn IObj IMapIterable Seqable))))
+      (clojure.lang Associative IFn IObj IMapIterable))))
 
 (defn no-op
   ([gf args]
@@ -156,11 +156,9 @@
        (valIterator [this]
                     (.iterator ^Iterable (vals (trace/choices this))))
 
-       java.lang.Iterable
+       Iterable
        (iterator [this]
-                 (.iterator
-                  (let [^Seqable choice-map (trace/choices this)]
-                    ^Iterable (.seq choice-map))))]))
+                 (.iterator ^Iterable (trace/choices this)))]))
 
 (defn ^:no-doc = [^Trace this that]
   (and (instance? Trace that)

diff --git a/test/gen/dynamic/trace_test.cljc b/test/gen/dynamic/trace_test.cljc
@@ -44,6 +44,9 @@
     (is (= :x (trace :addr)))))
 
 (deftest keys
+  (is (= {} (into {} (dynamic.trace/trace (gen []) [])))
+      "iterator works on an empty trace")
+
   (is (= #{:addr}
          (-> (dynamic.trace/trace (gen []) [])
              (dynamic.trace/assoc-subtrace :addr (choice-trace :x))