[DO NOT MERGE] Preliminary Ubuntu 20.04 images for both CPU and GPU as well as docs #312
Conversation
| # Find current Julia version on https://julialang.org/downloads/ | ||
| ARG JULIA_VERSION_SHORT="1.5" | ||
| ARG JULIA_VERSION_FULL="${JULIA_VERSION_SHORT}.1" | ||
| ENV JULIA_INSTALLATION_PATH=/opt/julia |
| # Find current Julia version on https://julialang.org/downloads/ | ||
| ARG JULIA_VERSION_SHORT="1.5" | ||
| ARG JULIA_VERSION_FULL="${JULIA_VERSION_SHORT}.1" | ||
| ENV JULIA_INSTALLATION_PATH=/opt/julia |
| [5] require(::Module, ::Symbol) at ./loading.jl:922 | ||
| ``` | ||
|
|
||
| This can even happen when running inside a VM on macOS. While this bug is confirmed and reproducable, there is currently no solution for it, cmp. [issue 311](https://github.com/probcomp/Gen.jl/issues/311). |
There was a problem hiding this comment.
It seems to me like duplicating the Dockerfiles to support both CPU and GPU is currently overkill, since none of Gen's native operations use GPU and (afaik) no one has ever asked us for help with GPU-related operations. I guess it's ok for now, since it's not that much more work to have the second image.
| ### Building Container | ||
| You can build Docker containers for Gen that either target CPU-only or GPU-enabled machines. | ||
| - Please run `docker build -f docker/GenCPU.dockerfile -t gen:cpu-ubuntu20.04 .` for the CPU image | ||
| - Please run `docker build -f docker/GenGPU.dockerfile -t gen:gpu-ubuntu20.04 .` if you want to use GPU acceleration | ||
| Both commands are supposed to be run from the main Gen.jl folder, not this subfolder. |
There was a problem hiding this comment.
Perhaps we should have the "easy version" be to pull a pre-built image from Docker Hub, and have building the container on one's own be the "advanced version"?
There was a problem hiding this comment.
Definitely, I just lack access rights to do that for you. But I would highly recommend that as well. docker run -it probcomp/gen:cpu-ubuntu20.04 bash should just work, absolutely.
| @@ -0,0 +1,41 @@ | |||
| # Gen Containerization | |||
There was a problem hiding this comment.
Perhaps rather than in its own markdown file, this should be added as a subsection at the bottom of docs/src/getting_started.md. I say bottom because I think Gen wants to present primarily as an ordinary Julia package rather than a monolithic stack (perhaps @marcoct can comment). Also, we should include in the beginning of this section an explanation of why the user might ever want to use these container instructions (e.g., for portability / saves the need to install anything other than Docker).
wget https://julialang.org/juliareleases.asc. That will not resolve, since this file was moved to https://julialang.org/assets/juliareleases.asc The PRed images work.--no-install-recommendsfor smaller image size, reduces number of layers caused by separate RUN lines in current imageWe might consider:
Happy to accommodate change requests - looking forward to feedback.