Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement _fill_array! for VectorTraceChoiceMap. #465

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Implement _fill_array! for VectorTraceChoiceMap. #465

wants to merge 2 commits into from

Conversation

femtomc
Copy link
Contributor

@femtomc femtomc commented Apr 18, 2022

No description provided.

@femtomc femtomc linked an issue Apr 18, 2022 that may be closed by this pull request
_fill_array! not implemented for VectorTraceChoiceMap #464
Open
@femtomc
Copy link
Contributor Author

femtomc commented Apr 18, 2022

I don't think this is correct yet -- it seems like it will still fail when get_choices returns StaticIRTraceAssmt -- which also doesn't implement to_array.

@femtomc femtomc marked this pull request as draft May 26, 2022 16:55
@ztangent
Copy link
Member

Now that I finally understand this part of the code better, why not just implement _fill_array! and _to_array for StaticIRTraceAssmt by converting to a StaticChoiceMap, and then calling the implemented methods for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_fill_array! not implemented for VectorTraceChoiceMap
2 participants
@femtomc @ztangent