20170711 iriss modules #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoct
requested changes
Jul 12, 2017
src/builtin_modules.jl
Outdated
|
|
||
| struct DiscreteUniform <: Gen.Module{Int64} end | ||
|
|
||
| function regenerate(::DiscreteUniform, x::Int64, a::Int64, b::Int64) |
There was a problem hiding this comment.
Please rename a and b to min and max or something equivalent, if that's what they are, and provide a comment explaining whether b is inclusive or exclusive.
test/runtests.jl
Outdated
| x = 5 | ||
| a = 1 | ||
| b = 10 | ||
| @test isapprox(regenerate(Gen.DiscreteUniform(), x, a, b), logpdf(DiscreteUniform(a, b), x)) |
There was a problem hiding this comment.
As you mentioned earlier, testing by just checking against the Distributions package isn't very good. It would be better to check against a value computed some other means (either different code, or manually computed). can you instead check that the value matches the manually computed value of log(1./9.) or log(1./10.) (depending on whether its inclusive or exclusive, I don't know)
|
@marcoct updated changes. The parameters are inclusive. |
marcoct
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added discrete uniform module with test. Has been tested manually and through the test script.