Epipolar #114
Epipolar #114
Conversation
|
@mugamma can we try and merge this? |
| u_ = x * fx / z + cx | ||
| v_ = y * fy / z + cy | ||
|
|
||
| # TODO: What is the right way of doing this? Returning infs? |
There was a problem hiding this comment.
I would cull to near and far instead of inf
There was a problem hiding this comment.
@mugamma I am indifferent here. I wanted a value that indicates out-of-bounds explicitly, e.g. when a point is behind the camera, I don't want to lift it to the near plane.
|
@mirkoklukas Do you know why this PR is changing so many of the imports in the test files? (Maybe is this a fork off of a different branch than the current main, and the new linting tool on main changed the order of the imports on main, so this commit is currently trying to revert this?) |
|
@georgematheos I have no clue, I can rebase and see if that changes anything |
|
@mirkoklukas thanks for checking that! @mirkoklukas have you switched to the new workflow that @eightysteele set up? This has been resulting in a CLI tool automatically fixing linting issues in the codebase when I commit things. If it is hard even with this to get the linting fixed we can ask Aaron for help. (I don't know if this tool fixes files not in the current commit which have gotten out of sync with the lint rules.) |
|
@mirkoklukas also, can we please run the tests and make sure they all pass before merging? |
|
@georgematheos Where is this workflow described? |
|
I ran the ruff linter locally |
|
@mirkoklukas for the new workflow, see the notion page linked here. |
|
👋 @mirkoklukas let me know if any questions about the workflow—happy to share a screen or give context! |
|
@eightysteele thanks! I will have a look at the doc first, and see if anything is unclear or I am running into trouble. |
No description provided.