Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add attestation bit position #30

Merged
merged 5 commits into from
May 28, 2024

Conversation

samcm
Copy link
Contributor

@samcm samcm commented May 27, 2024

Adds a new field to the payload for attestation which contains which aggregation bit was set. This is required to derive which validator created the attestation

@samcm samcm changed the title feat: add attestation bit feat: add attestation bit position May 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 2.94%. Comparing base (b94d32c) to head (c4398d8).
Report is 104 commits behind head on main.

Files Patch % Lines
eth/pubsub.go 0.00% 21 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #30      +/-   ##
========================================
- Coverage   7.75%   2.94%   -4.81%     
========================================
  Files          7      26      +19     
  Lines        400    3764    +3364     
========================================
+ Hits          31     111      +80     
- Misses       361    3642    +3281     
- Partials       8      11       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guillaumemichel guillaumemichel merged commit 90aecd7 into probe-lab:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants