Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated book1 firestore urls (pobml.ai) [Backward compatibility] #1100

Merged
merged 4 commits into from
Aug 6, 2022

Conversation

karm-patel
Copy link
Collaborator

@karm-patel karm-patel commented Aug 5, 2022

Description

closes #1054
Note that this change will reflected in printed version of book1 not the draft of book1.

  1. Previously code.probml.ai/book1/ was pointing to an individual notebook colab link, but since we have updated our redirection flow using notebooks.md, these URLs should be pointed to this common .md file.
  2. I have updated firestore with these updated URLs, some of the examples are below
    https://code.probml.ai/book1/2.3
    https://code.probml.ai/book1/8.17
  3. Removed duplicate notebooks in book1
  4. Note: We still need dummy notebooks "fig_8_26.ipynb"

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Aug 6, 2022

@murphyk murphyk merged commit 1f5d3f4 into probml:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect book1's probml.ai url to notebooks.md
2 participants