Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latexified/Jaxified Fig 11.20 neals_funnel.ipynb #918

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Latexified/Jaxified Fig 11.20 neals_funnel.ipynb #918

merged 2 commits into from
Jun 19, 2022

Conversation

karm-patel
Copy link
Collaborator

Description

Changes:

  1. Converted funnel_numpyro.ipynb to blackjax
  2. I have merged the old code for 11.20(a) & 11.20(b, c) into a single notebook - funnel_numpyro.ipynb. we are keeping this for comparison purposes.
  3. I have merged the updated code for 11.20(a) & 11.20(b, c) into a single notebook - neals_funnel.ipynb. So we need to change caption as well.

Potential problems/Important remarks

I have the following confusion in related section 11.6.4:

  1. In Eq. 11.123 & 11.126, I think we should replace v to v/2 (Image1 & Image2). I have written code considering v/2. (reference)
    Image1:
    image

Image2:
image

  1. The term variance v looks confusing to me (Image3), because if we are doing $exp(v/2)$ then shouldn't $v$ looks like log (variance)?

Image3:
image

Figure Number

Fig 11.20

Figures

Before PR:
image

After PR:
image

Issue

#890

cc: Dr. @murphyk, Prof. @nipunbatra

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Jun 19, 2022

Yes, v=log variance. Fine to use v/2 to match numpyro demo.

@murphyk murphyk merged commit 86a21b8 into probml:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants